Increase minimum number of ECS service containers #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwyeradam
force-pushed
the
eq-1835-increase-minimum-number-of-ecs-service-containers
branch
from
e9f42e5
to
b7fce9e
Compare
jonnyshaw89
approved these changes
Feb 16, 2018
MIslam92
approved these changes
Feb 16, 2018
MIslam92
suggested changes
Feb 16, 2018
dwyeradam
force-pushed
the
eq-1835-increase-minimum-number-of-ecs-service-containers
branch
from
82e3e80
to
c4bd43c
Compare
|
@MIslam92 conflict resolved. |
MIslam92
approved these changes
Feb 16, 2018
MIslam92
deleted the
eq-1835-increase-minimum-number-of-ecs-service-containers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Services with a single container running may experience downtime on a ECS cluster scale down.
By increasing the number to higher than 1 for PreProd and Prod then the service will not experience outage when the cluster scales back
We should also ignore changes for the desired_count. This means that if terraform is run when the environment has scaled then it wont be scaled back down by terraform
lifecycle { ignore_changes = ["desired_count"] }
hashicorp/terraform#4950